[digit50]

closes #795

With the msgspec converter, msgspec_attrs_unstructure_factory generated a class's unstructuring hook while its recursion probe still held classes in the working set. Field handlers that led back to a probed class were looked up during that time and came back as msgspec.to_builtins, so nested instances skipped registered hooks and lost private attributes. I changed both generation points (the private-attribute path and the one after the probe) so that, while any probe is active, the factory returns a hook that generates the real one on its first call, after the outermost probe has finished. Outside a probe the hook is generated immediately as before. Returning converter.unstructure instead is not enough: a namedtuple field caches the hooks of its element types during the probe, and a private class reached that way would then dispatch to itself forever.

The new tests in tests/preconf/test_msgspec_cpython.py cover a self-recursive class with a hooked datetime field, a mutually recursive pair where one class has a private attribute, and a private class reached through a namedtuple field. The first two fail on main with the reported output.

[codspeed]

Merging this PR will not alter performance

1 note

ℹ️ 64 benchmarks have no flamegraph

The flamegraph wasn't generated: the symbols of the profiling trace could not be resolved, because no information about the language frames was collected.

See affected benchmarks

✅ 64 untouched benchmarks

---

_{Comparing digit50:fix/msgspec-recursive-hooks (a0ff0f1) with main (2c6cf5b)¹}

Footnotes

1. No successful run was found on main (57333a2) during the generation of this report, so 2c6cf5b was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

[Tinche]

Pretty sure the performance regressions are unrelated. Can you add a link to the PR to the history entry?

Also I don't think this is the end of the story - for example, Event | None still won't work. I will think on a more general solution in the future.

[Tinche]

Thanks!