Repository navigation
Deprecate unused_tcp_port, unused_tcp_port_factory, unused_udp_port and unused_udp_port_factory fixtures - #1626
Open
saifmodan2006 wants to merge 2 commits into
Conversation
…nd unused_udp_port_factory fixtures The fixtures bind a temporary socket to port 0 and close it before returning the port number, so another process can claim the port before the test server starts. Emit a PytestDeprecationWarning on use and document the migration: bind port 0 and read the assigned port from the server socket or transport. Fixes pytest-dev#1614
…er warning defaults Add configuration for asyncio default fixture loop scope
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1626 +/- ##
==========================================
+ Coverage 94.86% 95.89% +1.03%
==========================================
Files 2 2
Lines 506 512 +6
Branches 60 60
==========================================
+ Hits 480 491 +11
+ Misses 21 16 -5
Partials 5 5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1614
The unused port fixtures bind a temporary socket to port 0 and close it before returning the port number, so another process can claim the port before the test server starts. This deprecates all four fixtures and documents how to migrate.
Changes:
Tests run: