fix: measure event payload limits in UTF-8 bytes - #266
Open
Shubham-Padkonde wants to merge 1 commit into
Open
Shubham-Padkonde wants to merge 1 commit into
Shubham-Padkonde wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Event payload validation uses sys.getsizeof(), which measures Python object storage rather than UTF-8 data size. This rejects valid ASCII payloads near the limit and accepts some oversized multibyte payloads.
Measure encoded UTF-8 bytes for both trigger and trigger_batch, retaining the existing 30 KiB and 10 KiB thresholds. Four regression cases cover exact-size ASCII and oversized three-byte characters across both methods; all four fail before the fix.
Validation: 67 unittest tests run successfully (one existing skip); git diff --check passes. Independent of #265.