Repository navigation
Fix/framework not in app publish - #45
Merged
Merged
Conversation
DeclarePurviewFrameworkOutputCopy declared Purview.SourceGeneratorFramework.dll as copy-to-output content so a dependent component's bin could load the unmerged generator. Copy-to-output content flows transitively through every ProjectReference, including OutputItemType="Analyzer" / ReferenceOutputAssembly="false" ones, so every app that referenced a generator's library by project received the compiler-host DLL in its build output, deps.json and publish output. That broke Native AOT, trimming and the Blazor WebAssembly AOT compiler. The target now copies the assembly into the component's own output with a plain Copy, recorded in FileWrites. A dependent component or test project that references the component as an assembly still gets it beside its bin through assembly-reference resolution; an analyzer-only reference never does. The packed analyzer is unchanged. Adds a Fixture.Application build-integration fixture and tests proving the DLL is absent from an analyzer consumer's and an app's build output, deps.json, publish output and ResolvedFileToPublish, and that the packed analyzer is byte-identical to the merged artifact. Bumps the version to 1.2.2.
BuildSdk 1.2.0 rewrites its managed .editorconfig files; the repository builds, tests and packs clean on it (just scrub + just pipeline-local-release, 6/6 packages valid).
The Purview.BuildSdk skills are now kept in source, installed by the skills CLI into the universal
.agents/skills/ location and nothing else:
npx -y skills@1 add purview-dev/build-sdk -s '*' -a universal -y
That is the eight purview-buildsdk-* skills, recorded with their source and hash in the new
skills-lock.json. This repository's own purview-sourcegenerator-* skills stay in skills/ only.
/.claude/ is now gitignored, and src/Directory.Build.props sets PurviewSkillsAgents to universal,
so the SDK's InstallPurviewSkills target no longer defaults to writing a copy for every agent.
InstalledSkillTests checks that the lockfile and .agents/skills/ agree, that no authored skill is
copied there, and that neither a .claude/skills/ folder nor a CLAUDE.md exists.
AGENTS.md said .agents/skills/ was gitignored. It is committed, together with skills-lock.json, and is written only by the skills CLI with -a universal. A new Installed skills section lists each skill, its source and when to load it, gives the commands to add, update and restore them, and states the rule that no .claude/ folder or CLAUDE.md is committed. The section on authored skills is renamed to match, and the copilot instructions point at the new section.
…own-skills rule Every purview repository installs purview-dev/engineering-playbook alongside build-sdk, with -a universal only. AGENTS.md lists the six skills and says that this repository's own skills in skills/ are for consumers and are never installed into its .agents/skills/.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.