Repository navigation
Conversation
Prepare .sync.yml for pdk update to pdk-templates main (8ca954f): set the hand edits to pdk-managed files that are still needed, so the template renders them, and drop settings main makes obsolete (the PR body lists each one kept or dropped). Co-Authored-By: Claude <noreply@anthropic.com>
Safe autocorrect (rubocop --autocorrect) of the offenses the pdk-templates main (8ca954f) rubocop profile adds, so the pdk update commit does not park them in .rubocop_todo.yml. Safe cops only: no behaviour change. Also drop the two `rubocop:disable/enable RSpec/MultipleExpectations` pairs in keytool_spec.rb. The template profile already excludes provider specs from that cop, and a `rubocop:enable` comment opts the file back in, which made the whole file fail under the template's Max: 1. Comments only. Co-Authored-By: Claude <noreply@anthropic.com>
Run pdk update (PDK 4.0.1) against pdk-templates main at 8ca954f. Pure pdk output, plus .rubocop_todo.yml regenerated with `rubocop --auto-gen-config --no-exclude-limit` (kept as is when only its header would change). Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pdk update of puppetlabs/puppetlabs-java_ks to pdk-templates main (8ca954f), with PDK 4.0.1.
Jira: https://perforce.atlassian.net/browse/MODULES-12012 (epic MODULES-11997)
Commits
Hand edits kept in .sync.yml
anchor_resourcestays disabled (was in .puppet-lint.rc)Hand edits dropped
gemsource_puppetcore = if ENV['PUPPET_FORGE_TOKEN'](template main's puppetcore gem-source logic)ENV['GEM_SOURCE_PUPPETCORE'] || gemsource_default(template main's puppetcore gem-source logic)def location_for(place_or_version, fake_version = nil, opts = {})(template main's puppetcore gem-source logic)[place_or_version, { require: false }.merge(opts)](template main's puppetcore gem-source logic)gem "voxpupuli-puppet-lint-plugins", '~> 7.0', require: false(template main's pin/condition for voxpupuli-puppet-lint-plugins)gem "puppet_litmus", '~> 2.8', require: false, platforms: [:ruby, :x64_mingw](template main's pin/condition for puppet_litmus)require 'puppetlabs-syntax/tasks/puppetlabs-syntax'(template main requires puppetlabs-syntax when puppetlabs_spec_helper 9 loads it)puppetlabs_spec_helper ~> 9.0(template main pins it per gem source; the override dropped that condition and listed the gem twice)gem "puppetlabs_spec_helper", '~> 9.0', require: false(template main's pin/condition for puppetlabs_spec_helper)Tests
cat-module(static, unit; full suite): pass, 134 passed, 0 failed🤖 Generated with Claude Code