Repository navigation
Renode model NC1: tolerate Mono's exit-134 abort only when the verdict line printed (AFD-150) - #311
Merged
Merged
Conversation
…he assertion did bite (AFD-150) Both CI failures had the same shape: verify.sh rejected the mutated archive, the .resc printed 'SMOKE FAIL: boot line not seen', and Mono then aborted in Environment.Exit(3) with 134. NC1 grepped for the literal 'exit 3', so a control whose assertion had bitten was reported broken, and with the job now required (AFD-149) each recurrence blocked a merge. NC1 now accepts, only for a detected Mono, rejection + the FAIL verdict line + no PASS line with exit 134; .NET keeps the exact exit 3. Measured: real .NET self-test NC0-NC5 pass; a stand-in Mono that prints the verdict then SIGABRTs passes; the abort without the verdict line, and the same abort from a runtime detected as .NET, both stay red. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017EKh2onUHpWSUiAEqWxfy2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The flake: 2 of 13 CI runs. Both had the same shape:
verify.shrejected the mutated archive (rc=1)..rescprintedSMOKE FAIL: boot line not seen.Environment.Exit(3)with 134.NC1 grepped for the literal
exit 3, so a control whose assertion had bitten was reported broken. The job is now required (AFD-149), so each recurrence blocked a merge.Fix: NC1 accepts exit 134 only for a runtime detected as Mono, and only together with rejection, the FAIL verdict line, and no PASS line. .NET keeps the exact exit 3. NC2 already grants Mono the same kind of allowance for load errors.
Measured:
Not reproduced on real Mono locally, because local Renode is the .NET build. This PR's CI runs the real Mono build. AFD-150 is resolved with the diagnosis.
rivet validate(0.41.1):Result: PASS.🤖 Generated with Claude Code
https://claude.ai/code/session_017EKh2onUHpWSUiAEqWxfy2