Skip to content

Various fixes - #4

Merged
ptoffy merged 5 commits into
mainfrom
various-fixes
Sep 20, 2026
Merged

ptoffy merged 5 commits into
mainfrom
various-fixes

Conversation

@ptoffy

@ptoffy ptoffy commented Sep 20, 2026

Copy link
Copy Markdown
Owner
  • Include C lib in LICENSE
  • Update CI to use swiftlang job
  • Add explicit 2y version
  • Zeroise p and s after use
  • Check 6th byte be a $ when verifying

@github-actions

github-actions Bot commented Sep 20, 2026 •

Copy link
Copy Markdown

Benchmark report

Commit 6345bd8 against main, cost 12. Full comparisons are in the run summary.

Platform Configuration Result
ubuntu-latest release ✅ No significant differences
ubuntu-latest debug ✅ No significant differences
macos-26 release ✅ No significant differences
macos-26 debug ✅ No significant differences
ubuntu-latest, release

New baseline 'pull_request' is WITHIN the 'main' baseline thresholds.

Hashing

Hash 12 Span

Metric p0 p25 p50 p75 p90 p99 p100 Samples
Malloc (total) * 1 1 1 1 1 1 1 5
Time (wall clock) (ms) * 245 245 245 246 247 247 247 5

Hash 12 Span with salt

Metric p0 p25 p50 p75 p90 p99 p100 Samples
Malloc (total) * 1 1 1 1 1 1 1 5
Time (wall clock) (ms) * 245 245 246 246 246 246 246 5

Hash 12 String

Metric p0 p25 p50 p75 p90 p99 p100 Samples
Malloc (total) * 2 2 2 2 2 2 2 5
Time (wall clock) (ms) * 246 246 246 246 246 246 246 5

Hash 12 [UInt8]

Metric p0 p25 p50 p75 p90 p99 p100 Samples
Malloc (total) * 1 1 1 1 1 1 1 5
Time (wall clock) (ms) * 246 246 246 246 247 247 247 5

Hash 12 [UInt8] with salt

Metric p0 p25 p50 p75 p90 p99 p100 Samples
Malloc (total) * 1 1 1 1 1 1 1 5
Time (wall clock) (ms) * 245 246 246 246 247 247 247 5

Hash 12 into OutputSpan

Metric p0 p25 p50 p75 p90 p99 p100 Samples
Malloc (total) * 0 0 0 0 0 0 0 5
Time (wall clock) (ms) * 245 245 245 245 245 245 245 5

Verifying

Verify 12 Span

Metric p0 p25 p50 p75 p90 p99 p100 Samples
Malloc (total) * 0 0 0 0 0 0 0 5
Time (wall clock) (ms) * 244 244 245 245 245 245 245 5

Verify 12 String

Metric p0 p25 p50 p75 p90 p99 p100 Samples
Malloc (total) * 0 0 0 0 0 0 0 5
Time (wall clock) (ms) * 244 244 244 244 244 244 244 5

Verify 12 [UInt8]

Metric p0 p25 p50 p75 p90 p99 p100 Samples
Malloc (total) * 0 0 0 0 0 0 0 5
Time (wall clock) (ms) * 244 245 245 245 245 245 245 5
ubuntu-latest, debug

New baseline 'pull_request' is WITHIN the 'main' baseline thresholds.

Hashing

Hash 12 Span

Metric p0 p25 p50 p75 p90 p99 p100 Samples
Malloc (total) * 1 1 1 1 1 1 1 1
Time (wall clock) (ms) * 1289 1289 1289 1289 1289 1289 1289 1

Hash 12 Span with salt

Metric p0 p25 p50 p75 p90 p99 p100 Samples
Malloc (total) * 1 1 1 1 1 1 1 1
Time (wall clock) (ms) * 1286 1286 1286 1286 1286 1286 1286 1

Hash 12 String

Metric p0 p25 p50 p75 p90 p99 p100 Samples
Malloc (total) * 2 2 2 2 2 2 2 1
Time (wall clock) (ms) * 1289 1289 1289 1289 1289 1289 1289 1

Hash 12 [UInt8]

Metric p0 p25 p50 p75 p90 p99 p100 Samples
Malloc (total) * 1 1 1 1 1 1 1 1
Time (wall clock) (ms) * 1289 1289 1289 1289 1289 1289 1289 1

Hash 12 [UInt8] with salt

Metric p0 p25 p50 p75 p90 p99 p100 Samples
Malloc (total) * 1 1 1 1 1 1 1 1
Time (wall clock) (ms) * 1286 1286 1286 1286 1286 1286 1286 1

Hash 12 into OutputSpan

Metric p0 p25 p50 p75 p90 p99 p100 Samples
Malloc (total) * 0 0 0 0 0 0 0 1
Time (wall clock) (ms) * 1287 1287 1287 1287 1287 1287 1287 1

Verifying

Verify 12 Span

Metric p0 p25 p50 p75 p90 p99 p100 Samples
Malloc (total) * 0 0 0 0 0 0 0 1
Time (wall clock) (ms) * 1303 1303 1303 1303 1303 1303 1303 1

Verify 12 String

Metric p0 p25 p50 p75 p90 p99 p100 Samples
Malloc (total) * 0 0 0 0 0 0 0 1
Time (wall clock) (ms) * 1304 1304 1304 1304 1304 1304 1304 1

Verify 12 [UInt8]

Metric p0 p25 p50 p75 p90 p99 p100 Samples
Malloc (total) * 0 0 0 0 0 0 0 1
Time (wall clock) (ms) * 1302 1302 1302 1302 1302 1302 1302 1
macos-26, release

New baseline 'pull_request' is WITHIN the 'main' baseline thresholds.

Hashing

Hash 12 Span

Metric p0 p25 p50 p75 p90 p99 p100 Samples
Malloc (total) * 1 1 1 1 1 1 1 4
Time (wall clock) (ms) * 285 285 294 309 324 324 324 4

Hash 12 Span with salt

Metric p0 p25 p50 p75 p90 p99 p100 Samples
Malloc (total) * 1 1 1 1 1 1 1 4
Time (wall clock) (ms) * 268 268 280 294 312 312 312 4

Hash 12 String

Metric p0 p25 p50 p75 p90 p99 p100 Samples
Malloc (total) * 2 2 2 2 2 2 2 4
Time (wall clock) (ms) * 264 265 276 283 289 289 289 4

Hash 12 [UInt8]

Metric p0 p25 p50 p75 p90 p99 p100 Samples
Malloc (total) * 1 1 1 1 1 1 1 4
Time (wall clock) (ms) * 287 288 291 292 318 318 318 4

Hash 12 [UInt8] with salt

Metric p0 p25 p50 p75 p90 p99 p100 Samples
Malloc (total) * 1 1 1 1 1 1 1 4
Time (wall clock) (ms) * 271 271 275 286 333 333 333 4

Hash 12 into OutputSpan

Metric p0 p25 p50 p75 p90 p99 p100 Samples
Malloc (total) * 0 0 0 0 0 0 0 4
Time (wall clock) (ms) * 270 271 281 298 325 325 325 4

Verifying

Verify 12 Span

Metric p0 p25 p50 p75 p90 p99 p100 Samples
Malloc (total) * 0 0 0 0 0 0 0 4
Time (wall clock) (ms) * 274 274 278 285 286 286 286 4

Verify 12 String

Metric p0 p25 p50 p75 p90 p99 p100 Samples
Malloc (total) * 0 0 0 0 0 0 0 4
Time (wall clock) (ms) * 292 292 293 306 308 308 308 4

Verify 12 [UInt8]

Metric p0 p25 p50 p75 p90 p99 p100 Samples
Malloc (total) * 0 0 0 0 0 0 0 3
Time (wall clock) (ms) * 303 304 313 441 441 441 441 3
macos-26, debug

New baseline 'pull_request' is WITHIN the 'main' baseline thresholds.

Hashing

Hash 12 Span

Metric p0 p25 p50 p75 p90 p99 p100 Samples
Malloc (total) * 1 1 1 1 1 1 1 2
Time (wall clock) (ms) * 701 701 701 740 740 740 740 2

Hash 12 Span with salt

Metric p0 p25 p50 p75 p90 p99 p100 Samples
Malloc (total) * 1 1 1 1 1 1 1 2
Time (wall clock) (ms) * 793 793 793 799 799 799 799 2

Hash 12 String

Metric p0 p25 p50 p75 p90 p99 p100 Samples
Malloc (total) * 2 2 2 2 2 2 2 2
Time (wall clock) (ms) * 711 711 711 719 719 719 719 2

Hash 12 [UInt8]

Metric p0 p25 p50 p75 p90 p99 p100 Samples
Malloc (total) * 1 1 1 1 1 1 1 2
Time (wall clock) (ms) * 687 687 687 710 710 710 710 2

Hash 12 [UInt8] with salt

Metric p0 p25 p50 p75 p90 p99 p100 Samples
Malloc (total) * 1 1 1 1 1 1 1 2
Time (wall clock) (ms) * 854 855 855 1081 1081 1081 1081 2

Hash 12 into OutputSpan

Metric p0 p25 p50 p75 p90 p99 p100 Samples
Malloc (total) * 0 0 0 0 0 0 0 1
Time (wall clock) (ms) * 1002 1002 1002 1002 1002 1002 1002 1

Verifying

Verify 12 Span

Metric p0 p25 p50 p75 p90 p99 p100 Samples
Malloc (total) * 0 0 0 0 0 0 0 2
Time (wall clock) (ms) * 938 938 938 945 945 945 945 2

Verify 12 String

Metric p0 p25 p50 p75 p90 p99 p100 Samples
Malloc (total) * 0 0 0 0 0 0 0 2
Time (wall clock) (ms) * 857 857 857 940 940 940 940 2

Verify 12 [UInt8]

Metric p0 p25 p50 p75 p90 p99 p100 Samples
Malloc (total) * 0 0 0 0 0 0 0 2
Time (wall clock) (ms) * 736 737 737 811 811 811 811 2

@ptoffy
ptoffy merged commit e49498b into main Sep 20, 2026
28 of 29 checks passed
@ptoffy
ptoffy deleted the various-fixes branch September 20, 2026 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant