Repository navigation
Step 73: two findings from the Drupal module's review, recorded - #182
Merged
Merged
Conversation
A cut-off ingredient tree looks complete to a caller (L3, reasoned), and softwareAgents()/digitalSourceTypes() de-duplicate in quadratic time over entries the uploader controls (L4, measured on 0.19.1). Notes only; each needs a draft spec before code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Records two findings from an independent review of the Drupal module
content_credentials(its NOTES Step 35, L3 and L4) that belong in this library. Notes only: no code, no spec yet; each needs a draft spec before code.ManifestStoreParserstops atMAX_INGREDIENTS = 64andMAX_INGREDIENT_DEPTH = 8(SPEC-045 AC5), and a caller cannot tell a cut-off tree from a complete one. Proposal:ManifestReport::ingredientsTruncated().softwareAgents()anddigitalSourceTypes()de-duplicate within_arrayover entries the uploader controls: 40,000 actions take about 1.9 s per call. The verifier route is bounded by its CBOR cap; the service and extension routes are not measured.Written 2026-10-11, committed now.