Repository navigation
SPEC-045 Amendment 4 / SPEC-042 Amendment 5: the verifier at ^0.6.1 - #178
Merged
Merged
Conversation
provemark/c2pa-verifier 0.6.1 reads an icon in a c2pa.databoxes store and checks its hash, where 0.6.0 refused it. SPEC-045 pinned that refusal as an exception on a C2PA Sign file with a site logo; on 0.6.1 the pinned test turned red as designed. The exception is withdrawn, the logo file joins the integration comparison, and the tested range moves to ^0.6.1 (conflict <0.6.1 || >=0.7).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
provemark/c2pa-verifier 0.6.1 reads an icon kept in a
c2pa.databoxesstore and checks its hash, where 0.6.0 refused it. The Drupal module C2PA Sign 1.4.11 (with c2patool 0.9.12) stores a site logo there in every manifest it writes.SPEC-045 (0.19.0) pinned that refusal as an exception on
spec045-c2pasign-logo.png: the verifier read the upload manifest's ingredient as untrusted, and by Amendment 2 everything below it. With 0.6.1 installed that pinned test turned red, as it was written to.^0.6.1(conflict<0.6.1 || >=0.7).VerifierVersionRangeTestaccepts a patch floor and pins 0.6.1.docs/readers.mdand ADR-0007 say why.No API change.
composer check: 519 passed. Integration against a local service with trust settings: 214 passed, including the logo file across all three readers.To be released as 0.19.1.