Repository navigation
Conversation
Neither extension was in the extension map, so they fell through to the
default text tag:
>>> tags_from_filename('photo.heic')
{'file', 'executable', 'text'}
HEIC is the default camera format on recent iPhones, and describing it as
text means hooks that process text files (pre-commit's end-of-file-fixer,
trailing-whitespace, and anything else gated on the text tag) will happily
rewrite binary photo data.
Add both next to the other image formats.
Member
|
we don't accept slop |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Neither
.heicnor.heifis in the extension map, so both fall through to the default text tag:HEIC is the default camera format on recent iPhones, and tagging it as text means anything gated on the
texttag will treat photo data as text. In pre-commit that isend-of-file-fixer,trailing-whitespace,mixed-line-endingand friends - they will happily rewrite binary image data.Compare
.avif,.webp,.tiff, which are all present as{'binary', 'image', ...}.Change
'hcl': {'text', 'hcl'}, + 'heic': {'binary', 'image', 'heic'}, + 'heif': {'binary', 'image', 'heif'},Tests
Two cases added to the filename table in
tests/identify_test.py:pytest tests -k "heic or HEIF or JPG"The 12 remaining failures are pre-existing on this Windows machine (missing
licensedependency and the executable-bit tests), and the count is identical with and without this change.