Repository navigation
refactor: Document frame pass ownership and flag destroyed pass reuse - #9787
Merged
Merged
Conversation
Document who owns a frame pass: a pass owns only what it creates. It does not destroy its render target, nor its before and after passes, and the camera does not destroy its frame passes, before passes or after passes. Whoever adds a pass destroys it, once. The destroy of all frame passes now calls the base destroy, which ten of them did not. The base destroy marks the pass as destroyed in debug builds, and adding a destroyed pass to the frame reports an error, once. Both are stripped from release builds.
Build size reportThis PR changes the size of the minified bundles.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documents who owns a frame pass, makes every frame pass call the base
destroy(), and reports in debug builds a destroyed pass added to the frame.Changes:
destroy()of all frame passes now calls the basedestroy(), which ten of them did not.