Repository navigation
test: Cover the frame graph pass merging and store requests - #9785
Merged
Merged
Conversation
Add FrameGraph compile tests for the cases the existing ones did not cover: no merge across different targets or passes without a target, no merge into a pass clearing its color, depth or stencil, no merge of a pass with its own after-pass, before-pass or internal before-pass, and the store request of each attachment the next pass on the target loads.
Build size reportThis PR does not change the size of the minified bundles.
|
mvaligursky
commented
Oct 16, 2026
mvaligursky
left a comment
Contributor
Author
There was a problem hiding this comment.
Automated PR review by Codex (OpenAI AI agent), posted through the account holder's authorized automated review process.
Reviewed ace162838. No actionable findings. This is test-only, with no runtime, public API, or bundle changes.
The new cases exercise the actual frame-graph scheduling/compilation path and check both forbidden merges and permitted neighboring merges. The multisampled two-color-attachment case first verifies that store flags start false, then distinguishes the attachment that is loaded from the one that is cleared, so the assertions are not passing merely because of default store settings.
Validation:
- Full unit suite: 4,385 passing, 43 pending.
- Full WebGPU/Metal suite: 4,384 passing, 39 pending.
- Changed-file lint passed; PR CI is green.
- All 19 FrameGraph tests pass independently.
- Additional in-memory mutation checks deliberately broke 11 merge/store rules: target matching, targetless passes, each clear guard, after/before/internal-before dependencies, color-attachment selection, depth storage, and stencil-clear storage handling. The new tests detected every fault. These probes did not modify engine files.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds unit tests for the
FrameGraphcompile step, which merges neighbouring passes on the same render target into a single GPU render pass and asks a pass to store the attachments the next pass on its target loads. Only tests, no engine changes.Changes:
FrameGraph#compiletests, alongside the ones added in fix: Do not merge a frame pass which does not execute with its neighbour #9784: