Repository navigation
Flatten nested animation profiles so they load from the gallery - #24
Merged
Merged
Conversation
The demo gallery only reads files at the top of each AnimationProfiles folder, so FlowFree, Switching-soldier and the pddl_grid_problems games could not be loaded. - FlowFree: split into FlowFree (edgy strategy) and FlowFree-Pre-Strategy, each with its domain, its own problems and the shared profile. - Switching-soldier: replace the 8 size-specific profiles (hard-coded x positions) with one profile that lays out ground cells with distributex; all 8 problems now sit beside one domain. Drop the duplicated domain copies and old_files. Fix the 3plus3 problem's name. - pddl_grid_problems: move Bloxorz, Lights-Out, Sokoban and Traffic-Rush to their own folders and update the project README links. Rename Bloxorz problem-basic-large to problem-large so the default problem is one the online planner solves. - Add covers and descriptions for the 7 new cards; list the new games in AnimationProfiles/Readme.md. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The demo gallery only reads files at the top of each
AnimationProfiles/<folder>. These profiles kept their problems in subfolders, so they couldn't be loaded. This PR adds 7 gallery cards.FlowFree/(2 domains, problems inEdgyStrategy/,Pre-Strategy/)FlowFree/(edgy) andFlowFree-Pre-Strategy/, each flat with its own domain, problems and the shared profileSwitching-soldier/: 8 size folders, each with a copy of the domain and a size-specific profilepddl_grid_problems/examples/{bloxorz,lights-out,sokoban,traffic-rush}Bloxorz/,Lights-Out/,Sokoban/,Traffic-Rush/; the project folder keeps its README (links updated), report, scripts and archived examplesOther changes:
ap_switching_soldier.pddlplaces cells withdistributex, so one profile works for every size. Ground labels are off; they overlapped at 20+ cells.prob_2plus2_with_3_clear. Removed the 8 duplicate domain files andold_files/.problem-basic-largetoproblem-largeso the default problem is one the online planner solves.AnimationProfiles/Readme.md.Test plan
planimation.planning.domains/upload/pddlwith the default BFWS planner. All 8 Switching-soldier sizes render with the shared profile.Known issues, not caused by this PR:
problem-largeand Lights-Outproblem5x5time out on the online planner.problem2_6x6_edgy_fdandproblem2_7x7_edgy_fdreturn only the initial state. They look written for Fast Downward; plans are inPlans/.problem2andproblem3fail withunhashable type: 'dict'.Depends on planimation/Frontend-JS#23 (file matching and natural sort). Without it, these cards' problem lists stay empty.
🤖 Generated with Claude Code