Skip to content

Toggle Required Metadata - v3.0.0.1, v2.2.2.2, v1.4.1.6 - #549

Open
iudizm wants to merge 4 commits into
pkp:mainfrom
lepidus:toggleRequiredMetadata-v3-v2-2-2-2-v1-4-1-6
Open

iudizm wants to merge 4 commits into
pkp:mainfrom
lepidus:toggleRequiredMetadata-v3-v2-2-2-2-v1-4-1-6

Conversation

@iudizm

@iudizm iudizm commented Sep 30, 2026

Copy link
Copy Markdown
  • Update with the latest releases for OJS 3.3, 3.4 and 3.5
  • Adjust the plugin summary and description.

@bozana

bozana commented Oct 14, 2026

Copy link
Copy Markdown

Hi @iudizm,

Thanks for the new releases! We now review plugin releases with the help of Claude. We installed 3.0.0.1 on OJS 3.5 and it works as described. Claude suggested a few improvements:

Main points

  • Workflow warning (3.0.0.1): the warning says "The verification e-mail was already sent" for every contributor without a verified ORCID iD, even if no email was ever sent. For example, it appears on articles published before the plugin was enabled, and it asks editors to "Resend Verification Email" to authors who never got one. It also stays after the plugin's rule is met. Could you pass orcidVerificationRequested to the component, use different wording for "not requested yet" and "requested, waiting", and show the warning only where the requirement applies?
  • ORCID check (3.0.0.1, 2.2.2.2): please count a contributor as verified only when an orcid is also stored (orcid && orcidIsVerified), as core's export plugins do.
  • OMP 3.3 (1.4.1.6): OMP's submission/form/step3.tpl sets additionalContributorsFields itself for the chapters grid. That overwrites your variable, so the list of missing details your error message mentions never appears on a press.
  • Defaults: all three requirements are on by default, and the settings are saved the first time any page reads them. So enabling the plugin immediately requires affiliation, biography and ORCID. Maybe save the defaults once on enable (or default to off), or mention the default in the gallery description?
  • version.xml (3.0.0.1, 2.2.2.2): please add ToggleRequiredMetadataPlugin and 1, so the plugin isn't loaded on every request where it's disabled.

Smaller points

  • manage() should return early when there's no context. In 1.4.1.6, it should call parent::manage($args, $request).
  • The release tarballs include Cypress tests, package files, resources/ sources and README images. These could be left out with export-ignore in .gitattributes.
  • The plugin description in the 2.2.2.2 locale files doesn't mention the biography.

None of these block the release. Would you like to address them before we merge, or should we merge this now and you include them in a next release?

Thanks!

…and 3.0.0.2

Signed-off-by: iudi <iudi@lepidus.com.br>
Signed-off-by: iudi <iudi@lepidus.com.br>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants