Repository navigation
build(go): Use Go version from go.mod in release workflow - #1355
Merged
Merged
Conversation
The releaser workflow installed Go 1.14, which cannot parse the `go 1.23.0` directive in go.mod, so `go mod tidy` in the goreleaser before hook failed and tag releases (v4.34.0, v4.35.0) were not built. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Contributor
API changelog (oasdiff)Doc-only edits (descriptions, examples) do not appear here. |
Sönke Behrendt (theSoenke)
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
releaserworkflow in phrase-go fails on every tag push (v4.34.0, v4.35.0). It sets up Go 1.14, which can't parsego 1.23.0ingo.mod, so the goreleaserbeforehookgo mod tidyfails withgo.mod:3: usage: go 1.23.Fix
go-version: 1.14->go-version-file: go.modso the release job always matches the moduleactions/setup-gov2 -> v5 (required forgo-version-file)actions/checkoutv2 -> v4 (Node 20 deprecation)test.ymlis unchanged (^1.14.2already resolves to a current Go).After merge
Re-run the release for v4.34.0 and v4.35.0 once the workflow is deployed to phrase-go.
🤖 Generated with Claude Code