Repository navigation
Use the configured docs build path in the documentation check - #7
Merged
Merged
Conversation
phpbbmodders/documentation is moving its default build location from ext/phpbbmodders/documentation/docs-build to store/phpbbmodders_documentation. Read phpbbmodders_documentation_docs_path so the check works for both, and check that a guest who loses access gets the login form. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
kaileymsnay
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
check_documentationwrote its probe build toext/phpbbmodders/documentation/docs-build, which is hardcoded. phpbbmodders/documentation is moving its default tostore/phpbbmodders_documentation, so the check now readsphpbbmodders_documentation_docs_pathfrom the board's config and works with both versions.It also adds one check: a guest who loses section access gets the login form rather than the page.
Claude ran the updated checks against phpbbmodders/documentation
mainand itsfix/validation-findingsbranch on a 3.3.19 test board, and all 10 passed.Investigated and written by Claude on behalf of William Jacoby (bonelifer).