Repository navigation
Add rename_upgrade.py: check upgrades from an old vendor name - #16
Merged
Merged
Conversation
Installs the old version of a renamed extension, upgrades the way an admin would, and checks that the migration history moved without anything running again, that ACP modules, settings and the old extension record were handled, and that the board and the extension's ACP pages still load. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
kaileymsnay
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
phpbb-test-board/rename_upgrade.py, which checks that an extension moved to a new vendor name (for examplermcgirr83/stopforumspam→phpbbmodders/stopforumspam) upgrades cleanly from the old one.It installs the old version, then upgrades the way an admin would. It checks that the new version refuses to enable while the old one is enabled, that the migration history moved to the new name with its original timestamps (so nothing ran again), that no ACP module, migration dependency, notification type or setting name still uses the old name, that settings are kept, and that the board and the extension's ACP pages load without PHP errors.
Claude ran it on the test board:
rmcgirr831.5.2 → current: 21/21 passedrmcgirr831.4.4 → current: 19/19 passedext.php: 7 failures. Every migration ran again and all settings went back to their defaults, which is why the move is needed.Also adds option tests to
tests/test-phpbb-test-board.shand documents the script in both READMEs.Investigated and written by Claude on behalf of William Jacoby (bonelifer).