Repository navigation
Add wiki article-link checks and screenshots - #15
Merged
Merged
Conversation
feature_checks.py gains a phpbbmodders/wiki check for [[ ]] links: the link to an existing article, a missing article marked as new, What links here, links in forum posts, brackets inside [code] left alone, and the editor button. screenshots.py gains the article links, What links here and the editor button. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
shots_wiki seeds a small wiki (sticky article, views, descriptions and a pending edit) and also takes the overview, article, edit, pending, compare and moderator-controls screenshots. Shooter.shot gains full_page for pages taller than the window. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds phpbbmodders/wiki to the test board tools, for its new
[[Article name]]links (phpbbmodders/phpbb-ext-wikiarticle-links).feature_checks.py: checks the link to an existing article, a missing article marked as new, the What links here list, a link in a forum post, brackets inside[code]left alone, and the editor button. The articles and post are stored through phpBB's own text parser.screenshots.py: an article with links (missing ones in red), the What links here list, and the editor button.Testing
Claude ran both on a 3.3.19 test board: 8 of 8 checks pass on the extension's
article-linksbranch, the link checks fail on itsmain, and the three screenshots were saved and checked. The tool's own test script passes.Investigated and written by Claude on behalf of William Jacoby (bonelifer).