Repository navigation
Translate the old-extension message in ext.php - #38
Merged
Merged
Conversation
ext.php refused to enable with a hard-coded English message while the old extension was still enabled. The message now comes from the install language file, as phpBB's validation policy requires. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ext.phprefused to enable with a hard-coded English message while the oldrmcgirr83/contactadminextension was still enabled. phpBB's validation policy requires user-facing text to come from language files, so the message now comes fromlanguage/en/install_contactadmin.php(CONTACTADMIN_DISABLE_OLD).Found during a validation pass on phpbbmodders/stopforumspam#68, whose
ext.phpcame from the same rename template.Testing
Claude ran these on a local phpBB 3.3.19 test board:
rmcgirr83/contactadminversion, then tried to enable this one: it refused with the translated message. After disabling the old copy, this one enabled.Investigated and written by Claude on behalf of William Jacoby (bonelifer).
🤖 Generated with Claude Code