Repository navigation
Fix the reset link in the activation emails - #33
Merged
Merged
Conversation
With user activation, the reset link could never be used: the reset form refuses inactive users, and activating the account clears reset_token. That email no longer gets a token or link; it tells the user to set a password with "Forgot password" after activating. With admin activation, the link only works once an administrator has activated the account. The email now says so, and points to "Forgot password" if activation comes after the link expires. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
kaileymsnay
approved these changes
Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #32, fixing the two edge cases found when testing it.
User activation. The reset link could never be used. The reset form refuses inactive users, and activating the account through
ucp.php?mode=activateclearsreset_token, so the link failed both before and after activation. This email no longer gets a token or a link. It tells the user to set a password with "Forgot password" after activating. The ACP messages for this mode say the same.Admin activation. Clicking the link before an administrator activates the account shows "The password reset token you supplied is invalid or has expired", although the same link works after activation. The email now says the link works only once the account is activated, and points to "Forgot password" if activation happens after the link expires.
No change for boards without activation, or when the admin ticks "activate" on the Add User page.
Claude tested this on a clean phpBB 3.3.19 board (PHP 8.4, SQLite), creating one user per case through the ACP page and following the links in the emails that were actually sent:
Investigated and written by Claude on behalf of William Jacoby (bonelifer).