Repository navigation
Conversation
When bind() raises, close the current socket and any earlier successful binds so ResourceWarning does not fire from leftover fds. Detach fd:// sockets on failure so the caller's descriptor stays open. Fixes pgjones#392
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
_create_socketshits a bind failure (for example EADDRINUSE), the socket that failed and any earlier successful binds were left open until GC, which shows up asResourceWarning: unclosed <socket.socket ...>.This closes the current socket on failure, closes earlier binds if the loop aborts, and uses
detach()forfd://sockets so the caller's file descriptor is not closed.Fixes #392