Repository navigation
Conversation
Python 3.14 can eager-start the Runner task. wait_for then calls timeout() with current_task() still None and the worker dies on startup. Fixes pgjones#351
Author
|
Closing this to narrow my open-source work to fewer projects. Anyone is welcome to pick the change up if it's useful. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #351. Same crash as #354.
_runusesasyncio.Runner.run(). On Python 3.14 that task can eager-start, so the firstawait asyncio.wait_for(...)inworker_serve(lifespan startup) runs withcurrent_task()stillNone. 3.14'stimeout()raisesRuntimeError: Timeout should be used inside a taskand the worker dies before it binds.Yield once inside the wrapped main so wait_for / TaskGroup see a real task. Tested
_runagainst wait_for.