Repository navigation
Add Inspector ECR findings evidence and vulnerability intake fetchers - #323
Merged
Merged
Conversation
Split from #300 (contributed by Lucid). Adds two fetchers on a shared Inspector collector: - aws_inspector_ecr_findings (EVD-INSPECTOR-ECR-FINDINGS): active Inspector findings per ECR image, image inventory and scan coverage, with partial-failure evidence (partial_failure, api_failures, collection_complete: false) when calls fail. - aws_inspector_ecr_report (issue_report, VULNERABILITY): converts the same APIs to a CSV for the existing pipeline intake uploader, with no S3/KMS export. All-or-nothing: refuses incomplete pagination, missing coverage and inventory mismatches. The aws_ecr_image_scanning changes from #300 are left out; they have a severity-count bug on enhanced scanning and will follow separately. Co-authored-by: Rocky Olsen <rolsen@lucidchart.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Native exports are still sent byte for byte. When a tool has no practical export, a fetcher may build the CSV from read APIs, provided it documents its columns, gives rows stable identities, refuses incomplete collection and doesn't pose as a native export. Replaces the one-off exception for aws_inspector_ecr_report with a general rule. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split from #300, contributed by Lucid (co-authored by Rocky Olsen). This takes the two new Inspector fetchers. The
aws_ecr_image_scanningchanges from #300 stay out because they have a severity-count bug on enhanced scanning (details on #300), and will follow separately.What's added
aws_inspector_ecr_findings(EVD-INSPECTOR-ECR-FINDINGS): evidence of active Inspector findings per ECR image, the image inventory and scan coverage. When calls fail it keeps the partial evidence (partial_failure,api_failures,collection_complete: false) and exits nonzero.aws_inspector_ecr_report(issue report, VULNERABILITY): builds a CSV from the same Inspector APIs for the existingparamify issues uploadpath, with no S3/KMS export. It is all-or-nothing: it refuses incomplete pagination, missing coverage and inventory mismatches.Tested end to end
Against a live AWS account (Inspector enabled, 5 real images, about 10k findings) and Paramify stage:
framework/.Known follow-ups (not blocking)
UNSUPPORTED_MEDIA_TYPE) blocks the whole report. Expected exclusions should be recorded as gaps, not blockers.INFORMATIONALandUNTRIAGEDseverities.🤖 Generated with Claude Code