Repository navigation
chore(ci): pin actions to commit SHAs and lint workflows with zizmor - #135
Merged
Merged
Conversation
Every action is pinned to a commit SHA and checkouts no longer persist the token. release-please gets its write permissions on the job only, plus a timeout and a concurrency group. A new workflows job runs zizmor so these rules stay enforced. govulncheck is installed at a fixed version, and Dependabot waits 7 days before proposing a new release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
uses:is pinned to the commit SHA of the newest release in its current major, with the version in a trailing comment. Dependabot keeps bumping them.persist-credentials: false.release-please.yml: workflow permissions are{}, withcontents: writeandpull-requests: writeon the job only. It has a 10 minute timeout and a concurrency group that queues runs.workflowsjob inci.ymlruns zizmor and fails on findings.v1.8.0instead of@latest. The vulnerability database is still fetched live. Dependabot does not bump this pin.actions: read, which is only needed on private repos.Why
zizmor reported 16 high severity findings on the old workflows, mostly unpinned actions and workflow-level write permissions. It reports none now, and
actionlintpasses.The repo now requires SHA-pinned actions, so the workflows on
canaryfail until this merges.