Repository navigation
feat(ui): SessionView, one conversation view for the chat and for agent sessions - #381
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
First step toward one conversation view for a chat and for an agent session. Today the chat's
ChatThreadwires the transcript and composer one way, and a host showing agent sessions wires the same pieces another way: a different layout, its own loading and error handling, no Escape to stop, and agent replies without the actions a chat reply has.SessionViewis the transcript with the composer at the foot of the scrolling column, banners above, files dropped on it going to the composer, and loading and error states. The host binds its own data and callbacks:onSend;turn(running,onStop) for a turn the chat provider doesn't run;onEdit,onRegenerate,onRetry,onNavigateBranch, which turn those on. Without them they don't show.ChatThreadis nowSessionViewbound to the chat provider. Nothing about the chat changes on screen: a host's 15 docs screenshots of its chat pages are pixel-identical before and after.Same behavior wherever the view is used
SessionView, so a host turn gets it too. The Stop button's tooltip always promised it.Composer
ComposerControls,ModelSelectorandAllocationSelectortakemodelandallocationas aBoundSetting(value,onChange,disabled). A session that owns its own model and allocation shows and changes those without moving the chat's selection. A bound allocation never auto-selects.ChatInputtakestools={false}for a composer the chat's tools don't apply to.ChatMessageList'squeueDeliverycan be a function, for a host whose queued messages reach the model at different times (some at the agent's next step, some after the reply).Testing
make checkpasses: 528 tests insrc/ai, including new ones forSessionView(Escape for a host turn and for the provider, Escape left to an open dialog, edit throughonEdit, no editing without it, error and loading), the agent reply's actions, a bound model pick,tools={false}, and per-message queue delivery.Checklist
make checkpassesproblem/messages/(none changed)