Repository navigation
feat(ui): icons say what they're for, and no two meanings share a drawing - #379
Merged
Merged
Conversation
…wing 43 icons are redrawn to show what they mean rather than the nearest stock shape, and 24 new ones cover meanings that borrowed another icon (provision, worker, workflow, logs, token, restart and more). NamespaceIcon, CommandShellIcon and QuickActionIcon replace KubernetesNamespaceIcon, PowershellIcon and ZapIcon, which stay as deprecated names. A test fails when two meanings share a drawing.
Contributor
Dependency graph benchmarkMedians of 3 runs in headless Chrome on a shared runner; lower is better. Base and head run in turn on the same machine. thousand
three-thousand
nested
|
This was referenced Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Icons now show what they're for, not the nearest stock shape, and no two meanings share a drawing. This follows the icon audit: you picked each drawing on the review board.
What's in it
ComputeIconis a chip, not a cloud.NodeIconis a server slab, not a chip.BucketIconis a pail, not a paint bucket.JobIconis a page with a clock, and its old checklist drawing moves toTodoIcon.PasswordIconis masked dots, not a key.Provision,Deprovision,Shared,Worker,Workload,CloudNetwork,WorkspaceMountRestart,Reset,Restore,Release,Revoke,Unsplit,LoadingWorkflow,Logs,Definition,Config,Variable,Report,Token,AiProvider,DirectorySync,BannerNamespaceIcon,CommandShellIconandQuickActionIconreplaceKubernetesNamespaceIcon,PowershellIconandZapIcon. The old names are kept as deprecated aliases, so nothing breaks.PinFilledcounts as a different drawing.Not in this PR
VerifiedIcon: no option was picked, so it isn't added.OwnerIconandDefaultIcon: both options were rejected on the board (crowns read as kings). They aren't added; core keeps using theFeaturedstar for them until there's a drawing that fits.Checks:
vitest(icons and stories, 388 tests),biomeandtscpass. Core moves to the new names in a follow-up.