Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Theme colors in place of the dark-mode patches; labels as chips
After the shared theme (v1.91), 67
[data-theme='dark']rules were still patching colors that light-mode rules hard-coded. Some of them had begun to work against the theme: the dark multi-select colors overrode the new warning tints, and the dark shadows were literal blacks. Headings, paths, and labels were also drawn in navy, a color neither the platform nor the other apps use for static text.What changed
--theme-warning-muted, with warning text mixed toward the text color;--theme-error.--theme-shadow-lg, which the theme sets per scheme.--theme-muted-panel-bg.--theme-linksite-wide. Conversation rows in the chat rail keep the text color in both schemes.Kept on purpose (16 rules):
Checked.