Repository navigation
Add expressive composition, piano/drum writing and a live keyboard - #46
Merged
Merged
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 262 |
| Duplication | 0 |
AI Reviewer: run a review on demand. To trigger the first review automatically, go to your organization or repository integration settings. AI can make mistakes. Always validate suggestions.
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generated pieces repeated rigid bar-sized harmony and drum patterns, and piano leads used the same single-note writer as other instruments. Composer 7 separates harmonic spans from instrumental metre, connects expressive phrases, writes coordinated piano hands and gives the drum kit shared groove/fill decisions.
Update thesis to 0.5/rules to 0.6.0 (R04/R05/R06/R07/R09/R11). MUSICAL_FLOW.md, PIANO_WRITING.md and DRUM_EXPRESSION.md document mechanisms, limits, replay and matched listening evidence. Complete fingering/pedal models, tempo maps and general instrument transitions remain future work.
Validation: 217 tests pass; affected Release build has no warnings/errors. Chromium verifies settings effects and persistence, independent non-drum parts, melody regeneration, saved-score replay, uninterrupted visualizer switches, tab keyboard navigation, mobile layout and generation feedback. Live keyboard checks cover held piano/damping, repeated keys, real two-finger touch, independent releases, cancellation, blur and navigation without browser exceptions. Captured composer-4 notes still replay byte-identical WAV audio.
Local preview: http://127.0.0.1:18088/song. Matched original auditions at /flow-comparison/index.html, /piano-comparison/index.html and /drum-comparison/index.html (isolated kit/full band). Full mixes are RMS-matched by attenuation only. These unblinded examples demonstrate mechanisms, not aesthetic success.
Refs #8, #9, #11, #12, #13, #16, #17, #18, #19, #37. These broader issues remain open.