Skip to content

PDChat: ConversationChanging lets the host cancel a conversation switch (#282) - #283

Merged
davidnmbond merged 1 commit into
mainfrom
fix/conversation-changing-hook
Oct 27, 2026
Merged

davidnmbond merged 1 commit into
mainfrom
fix/conversation-changing-hook

Conversation

@davidnmbond

Copy link
Copy Markdown
Contributor

Fixes #282. Adds Func<Guid, Task>? ConversationChanging, asked before a tab click, a sidebar choice or a new conversation shows another conversation; false cancels and a refused tab click reselects the tab still shown. Not asked for the conversation already shown; null behaves as today. Tests: 4 new in PDChatTests.ConversationChanging, PDChat 211 passing.

@codacy-production

codacy-production Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 11 complexity · 3 duplication

Metric Results
Complexity 11
Duplication 3

View in Codacy

🟢 Coverage ∅ diff coverage · +0.00% coverage variation

Metric Results
Coverage variation ✅ +0.00% coverage variation
Diff coverage ✅ ∅ diff coverage

View coverage diff in Codacy

Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (316b3a8) 18476 18447 99.84%
Head commit (1d16ad4) 18476 (+0) 18447 (+0) 99.84% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#283) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

AI Reviewer: run a review on demand. To trigger the first review automatically, go to your organization or repository integration settings. AI can make mistakes. Always validate suggestions.

Run reviewer

TIP This summary will be updated as you push new changes.

@davidnmbond
davidnmbond merged commit fce362e into main Oct 27, 2026
8 checks passed
@davidnmbond
davidnmbond deleted the fix/conversation-changing-hook branch October 27, 2026 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PDChat: let the host cancel a conversation switch (ConversationChanging)

1 participant