Repository navigation
feat: the table's switches use the one toggle: dice tray, roll choice… - #381
Merged
Merged
Conversation
…s, try on the map (switches 2) The dice tray's ANIMATION, a roll's choices before it is rolled (ADVANTAGE, PUSH) and the graph's TRY ON THE MAP now use ToggleSwitch, which passes a button's own attributes through (title, class, a click seen first) but never its role or state. The roll picker's rolls stay radios. Approved mockup docs/mockups/toggle-switch.html, 2026-10-29.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…s, try on the map (switches 2)
The dice tray's ANIMATION, a roll's choices before it is rolled (ADVANTAGE, PUSH) and the graph's TRY ON THE MAP now use ToggleSwitch, which passes a button's own attributes through (title, class, a click seen first) but never its role or state. The roll picker's rolls stay radios. Approved mockup docs/mockups/toggle-switch.html, 2026-10-29.
Summary
Test plan
Pre-merge checklist
Code quality:
Version & Release:
frontend/package.jsonversiondocker-compose.ymlAPP_VERSIONCHANGELOG.mdwith release notesBefore merging to main:
Related issues