Skip to content

feat: the table's switches use the one toggle: dice tray, roll choice… - #381

Merged
over2take merged 1 commit into
feature/system-builderfrom
sb/switches-2-table
Oct 29, 2026
Merged

over2take merged 1 commit into
feature/system-builderfrom
sb/switches-2-table

Conversation

@over2take

Copy link
Copy Markdown
Owner

…s, try on the map (switches 2)

The dice tray's ANIMATION, a roll's choices before it is rolled (ADVANTAGE, PUSH) and the graph's TRY ON THE MAP now use ToggleSwitch, which passes a button's own attributes through (title, class, a click seen first) but never its role or state. The roll picker's rolls stay radios. Approved mockup docs/mockups/toggle-switch.html, 2026-10-29.

Summary

Test plan

  • Tested locally
  • Tests pass

Pre-merge checklist

Code quality:

  • Code follows project style
  • No breaking changes (or clearly documented)
  • No console errors or warnings

Version & Release:

  • Version bumped? If releasing to users, update:
    • frontend/package.json version
    • docker-compose.yml APP_VERSION
    • CHANGELOG.md with release notes
  • GitHub Actions will auto-tag Docker images with the new version

Before merging to main:

  • All tests passing
  • PR reviewed and approved
  • Branch is up to date with main
  • No merge conflicts

Related issues

…s, try on the map (switches 2)

The dice tray's ANIMATION, a roll's choices before it is rolled (ADVANTAGE,
PUSH) and the graph's TRY ON THE MAP now use ToggleSwitch, which passes a
button's own attributes through (title, class, a click seen first) but never
its role or state. The roll picker's rolls stay radios. Approved mockup
docs/mockups/toggle-switch.html, 2026-10-29.
@over2take
over2take merged commit 0dc53ab into feature/system-builder Oct 29, 2026
6 checks passed
@over2take
over2take deleted the sb/switches-2-table branch October 29, 2026 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant