Repository navigation
Document client ID metadata document URLs on oauthClients.info - #68
Merged
Merged
Conversation
outline/outline#14015 ("Support OAuth Client ID Metadata Documents for MCP clients") lets the oauthClients.info clientId parameter be the URL of a client ID metadata document, not just a short public identifier. The client's details are then resolved from that document. The validator caps clientId at 1024 characters to accommodate these URLs. Expand the clientId description and add maxLength: 1024 on the oauthClients.info request schema. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vjh3qTCE35UBZipUus9vfz
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reviewed pull requests merged to outline/outline in the last day. The one change affecting a documented public API endpoint is outline/outline#14015 ("feat: Support OAuth Client ID Metadata Documents for MCP clients").
That PR lets the
oauthClients.infoclientIdparameter be the URL of a client ID metadata document, not just a short public identifier — when a URL is passed, the client's details are resolved from that document. The upstream validator now capsclientIdat 1024 characters to accommodate these URLs (OAuthClientValidation.maxClientIdLength).Changes to
POST /oauthClients.infoclientIddescription to note it may also be the URL of a client ID metadata document.maxLength: 1024to theclientIdrequest field, matching the enforced validation.Only
spec3.ymlwas hand-edited;spec3.jsonwas regenerated by the pre-commit hook. Spectral lint, operation-id, and sort checks pass.Other merged PRs reviewed — no spec change needed
POST /oauth/token(rejects HTTP Basic, requiresclient_secret_post). The/oauth/tokenendpoint is an OAuth 2.0 protocol endpoint referenced only by theOAuth2security scheme; its request format is not a documented API path, so there is no schema to update./oauth/authorize,/oauth/register,/.well-known/oauth-authorization-server) that are not documented as API paths in this spec, and adds DB fields (metadataExpiresAt, nullableteamId/clientSecret) that are not part of the publicOAuthClientpresenter output.chore:dependency upgrades (#14039, #14047, #14045, #14044, #14043, #14042, #14041, #14038, #14037), and Crowdin translation updates (#13966) — ignored per task guidance.🤖 Generated with Claude Code
https://claude.ai/code/session_01Vjh3qTCE35UBZipUus9vfz
Generated by Claude Code