Repository navigation
Accept a file object for array-form type with format: binary - #228
Open
takayamaki wants to merge 4 commits into
Open
takayamaki wants to merge 4 commits into
takayamaki wants to merge 4 commits into
Conversation
When coerce_value is off, type: ["string", "null"] with format: binary rejected an uploaded file object. pick_array_type found no matching type, so the value fell into the type-mismatch validator. A single type: string reaches the binary branch of the string validator and passes. Now the array form falls back to string when format is binary and string is listed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #215 (item 7).
When
coerce_valueis off,type: [string, "null"]withformat: binaryrejected an uploaded file object.A single
type: stringwithformat: binaryaccepts it.For an array-form
type, the validator picks the type from the class of the value.A file object matches none of the listed types, so it fell into the type-mismatch error.
A single
type: stringgoes to the string validator, which skips the check whenformatisbinary.Changes
formatisbinaryandstringis listed in the array-formtype, the validator now uses the string validator.The result is the same as a single
type: string.type: [integer, "null"]withformat: binarystill rejects a file object.With
coerce_valueon, the array form already passed, and it still does.I did not change how a file object is detected.
The string validator still accepts any non-String value for
format: binary, as before.