Repository navigation
images: drop the orphaned memcached pin - #2835
Merged
Merged
Conversation
latest/base.yml pins the Docker Hub memcached image (*-alpine), and etc/images.yml maps it to its registry path. Both were added in 88e97c1 (March 2022) for the patchman roles in osism.services, which ran memcached as a sidecar container. Those roles were removed in October 2023 (osism/ansible-collection-services 3c6f9d2e, #1162). Since then nothing has read the pin, but Renovate keeps bumping it. The matching docker_registry_memcached variable has already been dropped from osism/defaults (d3fecc2). The drift detector's image_orphan check does not flag this pin, because it only looks at aliases emitted by the manager images.yml render in osism/generics, and that render never emitted memcached. Kolla's memcached image, pinned in latest/openstack-*.yml, is a different image and is left untouched. Assisted-by: Claude:claude-opus-5-5 Signed-off-by: Roger Luethi <luethi@osism.tech>
ideaship
marked this pull request as ready for review
October 15, 2026 08:00
ideaship
added a commit
that referenced
this pull request
Oct 16, 2026
image_orphan starts from the aliases that the generics manager render emits. A pin in latest/base.yml that the render never carried is therefore invisible to it. The memcached pin, left behind when the patchman roles were removed, went unnoticed for three years because of this (#2835). Add an image-group plugin, release_pin_orphan, that starts from base.yml instead. It flags every docker_images key that neither of the two release transports reads: - generics environments/manager/images.yml, for the manager environment, and - container-image-osism-ansible files/src/templates/versions.yml.j2, for the services osism-ansible deploys. Any versions['<key>'] reference counts as a read, including one that only appears in a Jinja condition (osism, osism_ansible). Removing the pin is one possible fix, so the plugin errs towards keeping pins. The other runner images are not readers. container-image-kolla-ansible's versions.yml.j2 takes its versions from the Kolla image SBOM, and container-image-ceph-ansible reads only manager_version from base.yml. A mirror that copies a pinned image, such as metalbox's registry tarballs, is not a reader either: mirroring a tag does not deploy it. A finding has three possible fixes: wire the pin into versions.yml.j2 if a role deploys the image, remove it if its consumer is gone, or allowlist it if it waits for a planned role or is used outside the transports. Four pins are allowlisted: - pushgateway (osism/issues#1446) and openstack_database_exporter (osism/issues#1443), pinned ahead of roles still planned for Tally. - syft, the SBOM tool the image builds run, and sonic_vs, the SONiC virtual switch that testbed's containerlab topology runs. Both are used outside the two transports. Assisted-by: Claude:claude-opus-5-5 Signed-off-by: Roger Luethi <luethi@osism.tech>
berendt
pushed a commit
to osism/metalbox
that referenced
this pull request
Oct 16, 2026
container-images-manager-stable.yml carries the Docker Hub library/memcached image for the stable tarball, and update-container-images-stable.py keeps it at the tag the release pins. Its only consumer was the memcached sidecar of the patchman roles, which were removed from osism/ansible-collection-services in October 2023 (3c6f9d2e, osism/ansible-collection-services#1162). Since then no manager pulls it, so the tarball ships an image nothing uses. osism/release has dropped the orphaned pin (osism/release#2835). Releases cut after that carry no memcached key, so the updater would report the entry as unresolved. Releases up to 11.0.1 still pin it, but nothing pulls it there either. Drop the image from the list and from the updater's manager image map. The stable full tarball no longer carries library/memcached. Kolla's memcached image (memcached:2024.2, memcached:2025.1, release/2025.1/memcached) is a different image, deployed by osism apply memcached, and stays. Assisted-by: Claude:claude-opus-5-5 Signed-off-by: Roger Luethi <luethi@osism.tech>
berendt
pushed a commit
that referenced
this pull request
Oct 16, 2026
image_orphan starts from the aliases that the generics manager render emits. A pin in latest/base.yml that the render never carried is therefore invisible to it. The memcached pin, left behind when the patchman roles were removed, went unnoticed for three years because of this (#2835). Add an image-group plugin, release_pin_orphan, that starts from base.yml instead. It flags every docker_images key that neither of the two release transports reads: - generics environments/manager/images.yml, for the manager environment, and - container-image-osism-ansible files/src/templates/versions.yml.j2, for the services osism-ansible deploys. Any versions['<key>'] reference counts as a read, including one that only appears in a Jinja condition (osism, osism_ansible). Removing the pin is one possible fix, so the plugin errs towards keeping pins. The other runner images are not readers. container-image-kolla-ansible's versions.yml.j2 takes its versions from the Kolla image SBOM, and container-image-ceph-ansible reads only manager_version from base.yml. A mirror that copies a pinned image, such as metalbox's registry tarballs, is not a reader either: mirroring a tag does not deploy it. A finding has three possible fixes: wire the pin into versions.yml.j2 if a role deploys the image, remove it if its consumer is gone, or allowlist it if it waits for a planned role or is used outside the transports. Four pins are allowlisted: - pushgateway (osism/issues#1446) and openstack_database_exporter (osism/issues#1443), pinned ahead of roles still planned for Tally. - syft, the SBOM tool the image builds run, and sonic_vs, the SONiC virtual switch that testbed's containerlab topology runs. Both are used outside the two transports. Assisted-by: Claude:claude-opus-5-5 Signed-off-by: Roger Luethi <luethi@osism.tech>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the Docker Hub
memcached(*-alpine) pin fromlatest/base.ymland its registry-path entry frometc/images.yml.Both were added in 88e97c1 for the patchman roles in
osism.services, which ran memcached as a sidecar container. Those roles have since been removed, so nothing reads the pin, but Renovate keeps bumping it:The matching
docker_registry_memcachedvariable has already been dropped fromosism/defaults(osism/defaults@d3fecc2).The drift detector's
image_orphancheck does not flag this pin, because it only looks at aliases emitted by the managerimages.ymlrender inosism/generics, and that render never emitted memcached.Kolla's memcached image, pinned in
latest/openstack-*.yml, is a different image and is left untouched.🤖 Generated with Claude Code