Repository navigation
check-osism-images: commit label on all images - #2829
Merged
Merged
Conversation
The check required the label de.osism.commit.release only on kolla-ansible, and only as an exact match. The image repositories now label their images with the full commit of the release repository. Check the label on every image. It is compared by prefix of at least seven characters, so short and full hashes both pass. A present label is always checked. A missing label fails only from a per-image version on (COMMIT_LABEL_SINCE); kolla-ansible has carried it since 0.20261001.0. Until the other images ship the label they are checked by push time as before, which stays in place for every image. Assisted-by: Claude:claude-sonnet-5-5 Signed-off-by: Roger Luethi <luethi@osism.tech>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
check-osism-images.shcomparedde.osism.commit.releasewith the release tag only for kolla-ansible, exactly, and checked the other four images by push time. The image repositories now label all their images with the full release commit (osism/issues#1463), so the check covers all five:COMMIT_LABEL_SINCE). kolla-ansible has carried the label since0.20261001.0; the other four images get their entries once their first labelled version is tagged.The README section "Checking the other images of a tag" describes the label check.
Verification
tox -e drift-test: 991 passed, 2 skipped. New tests cover full and short hashes, a different or too-short label, a missing label before and from the cutoff, an image without a cutoff, numeric version ordering, and two end-to-end runs.🤖 Generated with Claude Code