Repository navigation
Compare boolean image properties like the others - #1313
Merged
Merged
Conversation
Member
|
Can you please bump the version with the same commit? I think this makes more sense. The renovate commit will be closed automatically after. |
openstacksdk read hw_boot_menu, hw_vif_multiqueue_enabled and os_require_quiesce with bool(), so a stored "false" came back as True (https://bugs.launchpad.net/openstacksdk/+bug/2169133), and set_properties wrote them whenever a definition set them rather than compare them. openstacksdk 4.21.0 parses them as booleans, so update to it, compare them like every other property, and write them only when they differ. test_set_properties_writes_only_what_differs asserted the misreading, which is what fails with 4.21.0; it now checks that a stored "true" is left alone and a stored "false" corrected, and fails with 4.20.0. Assisted-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: Tore Anderson <tore@redpill-linpro.com>
toreanderson
force-pushed
the
drop-sdk-bool-workaround
branch
from
October 15, 2026 05:37
6ff8201 to
77a6b5f
Compare
Contributor
Author
|
Done, the bump is now part of the commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates openstacksdk to 4.21.0 in the same commit, superseding #1309:
test_set_properties_writes_only_what_differsasserted the openstacksdk bug that 4.21.0 fixes, so the bump can't pass CI on its own.openstacksdk read
hw_boot_menu,hw_vif_multiqueue_enabledandos_require_quiescewithbool(), so a stored"false"came back asTrue(openstacksdk bug 2169133). #1297 therefore wrote these three whenever a definition set them, rather than comparing them. openstacksdk 4.21.0 parses them properly (change 1008410). It readstrue/false,yes/no,1/0andon/offin any case, and an unrecognised value asFalse.Change
SDK_MISREAD_PROPERTIES, so these three properties are compared like every other one and written only when they differ.Testing
test_set_properties_writes_only_what_differs:"true"is left alone, and a stored"false"is corrected.🤖 Generated with Claude Code