Repository navigation
kolla: Use OSISM's Gnocchi pool name - #333
Merged
Merged
Conversation
When OSISM deploys Ceph, it creates the Gnocchi pool as "metrics" (openstack_gnocchi_pool in 099-ceph.yml) and grants client.gnocchi access to that pool only. Kolla renders gnocchi.conf's ceph_pool from ceph_gnocchi_pool_name, whose upstream default (mirrored in 001-ceph.yml) is "gnocchi". Gnocchi on Ceph therefore points at a pool OSISM does not create and its key cannot access, unless the configuration repository overrides the name. It is the only one of the five OpenStack pools whose names differ. cfg-cookiecutter has carried ceph_gnocchi_pool_name: "metrics" since 2020 to cover this, and configuration repositories copy it. Derive ceph_gnocchi_pool_name from openstack_gnocchi_pool.name when OSISM deploys Ceph, using the same signal as the Ceph mgr exporter (a non-empty ceph-mgr group). With an external Ceph cluster OSISM creates no pools, so the name stays at upstream's "gnocchi". Resolved with ansible against this tree: "metrics" with a ceph-mgr host, "gnocchi" with an empty ceph-mgr group, and a site's own ceph_gnocchi_pool_name or renamed openstack_gnocchi_pool wins in both cases. The kolla drift detector reports nothing to act on. Checked on a 2026.1 cluster that deploys Ceph with cephadm, with the configuration repository's ceph_gnocchi_pool_name removed: osism apply -a config gnocchi renders ceph_pool = gnocchi with the previous defaults and ceph_pool = metrics with this change. Repositories generated from cfg-cookiecutter already set "metrics", so the effective value does not change for them. Once a release carries this, the template line is a restatement and can go. Assisted-by: Claude:claude-opus-5-5 Signed-off-by: Roger Luethi <luethi@osism.tech>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When OSISM deploys Ceph, it creates the Gnocchi pool as
metrics(openstack_gnocchi_poolin099-ceph.yml) and grantsclient.gnocchiaccess to that pool only. Kolla rendersgnocchi.conf'sceph_poolfromceph_gnocchi_pool_name, whose upstream default (mirrored in001-ceph.yml) isgnocchi. So unless the configuration repository overrides the name, Gnocchi points at a pool OSISM does not create and its key cannot access. It is the only one of the five OpenStack pools whose names differ. cfg-cookiecutter has carriedceph_gnocchi_pool_name: "metrics"since 2020 to cover this, and configuration repositories copy it.This derives
ceph_gnocchi_pool_namefromopenstack_gnocchi_pool.namewhen OSISM deploys Ceph, using the same signal as the Ceph mgr exporter (a non-emptyceph-mgrgroup). With an external Ceph cluster OSISM creates no pools, so the name stays at upstream'sgnocchi.Repositories generated from cfg-cookiecutter already set
metrics, so their effective value does not change. Once a release carries this, the template line is a restatement and can go.Testing
metricswith a ceph-mgr host,gnocchiwith an empty ceph-mgr group. A site's ownceph_gnocchi_pool_name, or a renamedopenstack_gnocchi_pool, wins in both cases.ceph_gnocchi_pool_nameremoved:osism apply -a config gnocchirendersceph_pool = gnocchiwith the previous defaults andceph_pool = metricswith this change.🤖 Generated with Claude Code