Repository navigation
registries: drop two registries nothing reads - #325
Merged
Merged
Conversation
docker_registry_memcached and docker_registry_zookeeper in all/099-registries.yml have no reader in any OSISM repository, in upstream kolla-ansible or ceph-ansible, or in the galaxy roles the release pins. docker_registry_memcached was read by the patchman roles in osism.services, which were removed in October 2023 (3c6f9d2e, #1162). docker_registry_zookeeper was never read by an Ansible role. The last references to either were the patchman_memcached_image and zookeeper_image entries in container-image-osism-ansible's templates/images.yml.j2. osism apply never loaded the rendered file, and the template was removed in 6671813. The drift check's defaults_orphan plugin reports both variables as set but unread. Remove them. Assisted-by: Claude:claude-opus-5-5 Signed-off-by: Roger Luethi <luethi@osism.tech>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docker_registry_memcachedanddocker_registry_zookeeperinall/099-registries.ymlhave no reader in any OSISM repository, in upstream kolla-ansible or ceph-ansible, or in the galaxy roles the release pins.docker_registry_memcachedwas read by the patchman roles in osism.services, removed in Remove patchman roles ansible-collection-services#1162.docker_registry_zookeeperwas never read by an Ansible role.The last references to either were the
patchman_memcached_imageandzookeeper_imageentries in container-image-osism-ansible'stemplates/images.yml.j2.osism applynever loaded the rendered file, and the template has since been removed (osism/container-image-osism-ansible@6671813).The
defaults_orphanplugin of osism/release's drift check reports both variables as set but unread, which fails therelease-tox-driftperiodic job.🤖 Generated with Claude Code