Repository navigation
ceph: Default ceph_image_version to the Ceph release - #317
Merged
Merged
Conversation
ceph_docker_image_tag, which the cephadm plays use to select the ceph-daemon image, is defined from ceph_image_version, and nothing in osism/defaults defines ceph_image_version itself. Until now the ceph-ansible container always supplied it through its versions.yml. A deployment that runs Ceph with cephadm does not run that container, so on the latest track the variable is undefined. Default it to ceph_version, which is the rolling ceph-daemon tag for that release (reef, squid, tentacle) and exactly what the ceph-ansible image renders on the latest track today. Release pins still win: numbered releases render ceph_image_version in the osism-ansible and ceph-ansible versions files, which the inventory reconciler loads after these defaults. This matches how the cephclient role already defaults cephclient_version to ceph_version. Assisted-by: Claude:claude-opus-5-5 Signed-off-by: Roger Luethi <luethi@osism.tech>
This was referenced Oct 1, 2026
This was referenced Oct 2, 2026
ideaship
marked this pull request as ready for review
October 2, 2026 10:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
all/002-images-ceph.ymldefinesceph_image_version: "{{ ceph_version }}".Why
ceph_docker_image_tag, which the cephadm plays use to select the ceph-daemon image, is defined fromceph_image_version, and nothing in osism/defaults defined that variable. The ceph-ansible container always supplied it; a cephadm deployment runs no ceph-ansible container, so on the latest track it was undefined.The fallback is the rolling ceph-daemon tag for the release (
reef,squid,tentacle), which is exactly what the ceph-ansible image renders on the latest track today. Release pins still win: numbered releases renderceph_image_versionin the osism-ansible and ceph-ansible versions files, which the inventory reconciler loads after these defaults. This matches the cephclient role, which already defaultscephclient_versiontoceph_version.Part of
🤖 Generated with Claude Code