Repository navigation
kolla: use upstream OIDC forwarded headers var - #313
Merged
Merged
Conversation
all/099-kolla.yml set keystone_oidc_forward_header to "X-Forwarded-Proto", but kolla-ansible has never read that variable. It was read only by the custom wsgi-keystone.conf overlays in the testbed and the cookiecutter with_keycloak option, both removed in February 2025. Since then the default has had no effect. kolla-ansible's equivalent is keystone_federation_oidc_forwarded_headers (role default ""), available from 2025.1 on. It is rendered as OIDCXForwardedHeaders into the Keystone vhost (wsgi-keystone.conf.j2 on 2025.1, httpd-keystone.conf.j2 from 2025.2 on), and only when keystone_enable_federation_openid is true. Set the upstream variable instead, with the same value. mod_auth_openidc can trust the header: kolla's HAProxy frontends delete any client-supplied X-Forwarded-Proto and set it themselves on TLS connections. Deployments without OIDC federation render nothing, so they are unaffected. On 2024.1 and 2024.2 the variable is unknown to the role and ignored, as the old one was. Closes: #312 Assisted-by: Claude:claude-opus-5-5 Signed-off-by: Roger Luethi <luethi@osism.tech>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
all/099-kolla.ymlsetkeystone_oidc_forward_header: "X-Forwarded-Proto", but no kolla-ansible release reads that variable. It was read only by the customwsgi-keystone.confoverlays in the testbed and the cookiecutterwith_keycloakoption, both removed in February 2025, so the default has had no effect since.This replaces it with the variable kolla-ansible actually uses,
keystone_federation_oidc_forwarded_headers(role default"", available from 2025.1 on), with the same value. It is rendered asOIDCXForwardedHeadersinwsgi-keystone.conf.j2(2025.1) andhttpd-keystone.conf.j2(2025.2 and later), and only whenkeystone_enable_federation_openidis true.X-Forwarded-Protoand set it themselves on TLS connections.Once this merges, the OIDC federation guide can drop its explicit setting of this variable:
Closes #312
🤖 Generated with Claude Code