Repository navigation
Warn in the save menu when the bom table is filtered - #595
Open
emincan2000 wants to merge 1 commit into
Open
emincan2000 wants to merge 1 commit into
emincan2000 wants to merge 1 commit into
Conversation
Saving or copying the bom table exports only the visible rows. Filter, ref lookup and the front/back side buttons all hide rows, but the side filter in particular is easy to miss, so an exported bom can silently be incomplete. Show a warning below the csv/txt buttons listing what is filtering the table. The side filter is only reported when the other side actually has components. Fixes openscopeproject#481
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #481, following the suggestion there to put a warning text in the export menu.
Saving the bom table as csv/txt (and the copy button) exports only the rows currently shown. The filter box, ref lookup and the F/B side buttons can all hide rows, and the side buttons are easy to overlook, so the exported bom can be incomplete without the user noticing.
This adds a line under the csv/txt buttons, shown only while something hides rows, saying what it is, e.g.
Table is filtered (front side only, filter), saved file will not contain all rows.Fhides nothing, so no warning.populateBomTable(), which every filter, side and mode change already goes through.Testing
Generated with
--include-netsfrom the KiCad 9 demo boardspic_programmer(all parts on front) andvideo(both sides), then driven in headless Chromium:front side only(47 rows)back side only(0 rows)back side only(32 rows)rfilterfilterR1filter, ref lookupfilter, ref lookupChecked in light and dark mode, no console errors.
This PR was prepared with the help of an AI coding assistant (Claude). The tests above were actually run as described.