MNT Mock live server call in test_download_task (test_task.py) - #1763
Open
Prakritibhandari07 wants to merge 1 commit into
Open
Prakritibhandari07 wants to merge 1 commit into
Prakritibhandari07 wants to merge 1 commit into
Conversation
20 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Metadata
Details
This PR mocks the live
get_task()call inOpenMLTaskTest.test_download_task(tests/test_tasks/test_task.py) usingunittest.mock, so subclasses no longer hit the real OpenML server for this test — part of the broader effort in #1649 to replace live server calls with mocks across the test suite.I verified
tests/test_tasks/test_regression_task.py::test_download_taskpasses fully offline with this change.Note:
test_get_X_and_Yin subclasses still depends ontest_supervised_task.pybeing mocked separately (see PR #1691, currently open/unmerged) — that's out of scope for this PR.