test: Mock live server call for clustering tasks (#1649) - #1760
Open
sumitsaraswat362 wants to merge 1 commit into
Open
sumitsaraswat362 wants to merge 1 commit into
sumitsaraswat362 wants to merge 1 commit into
Conversation
Replaces the @pytest.mark.production_server() call in test_list_clustering_task with a mocked requests.Session.request using a saved XML response. Partial fix for openml#1649.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially addresses #1649.
Replaces the
@pytest.mark.production_server()decorator intest_list_clustering_task(intest_task_functions.py) with amock.patchofrequests.Session.request, returning a saved XML response of real clustering tasks.This prevents the test from hitting the live OpenML production server, removing a point of failure for CI.