Follow-up to Clip negative atom densities: Cleanup of redundant warnings and clips - #4170
Merged
paulromano merged 1 commit intoOct 5, 2026
Merged
Conversation
paulromano
approved these changes
Oct 5, 2026
paulromano
left a comment
Contributor
There was a problem hiding this comment.
Ah yes, I love PRs that are all red! 🔪 Thanks for the cleanup @yrrepy!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
What's this? Yes a PR that only removes lines of code.
Yay!
A sweep-up of lingering warning statements and positivity enforcement, prior to negative atom density clipping being moved closer to the CRAM solver by #3879
Because of the clip in
abc.pyThese lingering else statements are no longer reachable.
They are redundant, in effect: dead code