Skip to content

Feat/benchmark driver architecture - #58

Merged
amh1k merged 4 commits into
mainfrom
feat/benchmark-driver-architecture
Oct 19, 2026
Merged

amh1k merged 4 commits into
mainfrom
feat/benchmark-driver-architecture

Conversation

@amh1k

@amh1k amh1k commented Oct 17, 2026

Copy link
Copy Markdown
Collaborator

Summary

Closes #56
Introduce a modular benchmark driver architecture and structured runner metrics, following the design discussion in #49.

Changes

  • Add a driver registry and pgbench implementation that owns option defaults, strict validation, connection handling, and workload preparation.
  • Accept explicit driver and nested options in run requests, retaining the legacy pgbench request format for compatibility.
  • Keep Kubernetes Job/Secret creation, scheduling, log collection, and cleanup in the shared coordinator.
  • Record the driver, runner image, and effective options in run snapshots.
  • Emit versioned pgbench metrics through /dev/termination-log and return them alongside logs in run status responses.
  • Preserve execution status when metrics are missing or invalid, filter sensitive metadata, and protect stored results with defensive copies.

Validation

  • Backend race tests and go vet pass.
  • Tests cover driver preparation, shared execution, metrics decoding, authorization, redaction, storage, and cleanup.
  • Metrics remain available when logs are truncated.
  • Live Kubernetes verification remains pending.

Follow-up

Helm driver configuration and frontend integration will be handled separately.

amh1k added 4 commits October 17, 2026 12:10
Signed-off-by: amh1k <abdulmoizx97@gmail.com>
…sages

Signed-off-by: amh1k <abdulmoizx97@gmail.com>
…oordinator

Wire driver selection and request preparation into the API, retain safe run snapshots, and make Job and Secret construction generic. Preserve benchmark output while redacting passwords and credential URIs.

Signed-off-by: amh1k <abdulmoizx97@gmail.com>
Signed-off-by: amh1k <abdulmoizx97@gmail.com>
@amh1k
amh1k requested a review from spron-in October 19, 2026 08:15
@amh1k
amh1k merged commit f3b28e4 into main Oct 19, 2026
5 checks passed
@amh1k
amh1k deleted the feat/benchmark-driver-architecture branch October 19, 2026 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement backend benchmark driver architecture and structured metrics

1 participant