Repository navigation
Feat/benchmark driver architecture - #58
Merged
Merged
Conversation
Signed-off-by: amh1k <abdulmoizx97@gmail.com>
…sages Signed-off-by: amh1k <abdulmoizx97@gmail.com>
…oordinator Wire driver selection and request preparation into the API, retain safe run snapshots, and make Job and Secret construction generic. Preserve benchmark output while redacting passwords and credential URIs. Signed-off-by: amh1k <abdulmoizx97@gmail.com>
Signed-off-by: amh1k <abdulmoizx97@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #56
Introduce a modular benchmark driver architecture and structured runner metrics, following the design discussion in #49.
Changes
driverand nestedoptionsin run requests, retaining the legacy pgbench request format for compatibility./dev/termination-logand return them alongside logs in run status responses.Validation
go vetpass.Follow-up
Helm driver configuration and frontend integration will be handled separately.