Repository navigation
fix: parse sourcelib with packaging Version.release in openedx-events - #606
luisfelipec95 wants to merge 1 commit into
Conversation
|
Thanks for the pull request, @luisfelipec95! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
4919fe0 to
8875ef3
Compare
da324f3 to
9ca72be
Compare
bmtcril
left a comment
There was a problem hiding this comment.
Just a couple of little things, otherwise it looks good to me. Will you also be doing the follow-on PRs for the event bus repos?
| - sourcehost (str): physical source of the event. | ||
| - time (datetime): (optional) timestamp when the event was sent with UTC timezone. | ||
| Defaults to current time in UTC. See OEP-41 fordetails. | ||
| - sourcelib (tuple of ints): Open edX Events library version. A tuple was |
There was a problem hiding this comment.
Can you add a note here that only the release segment is kept and that additional information (pre/post/dev etc) is dropped?
| import traceback | ||
| from pprint import PrettyPrinter | ||
|
|
||
| from packaging.version import Version |
There was a problem hiding this comment.
We should add packaging as a direct dependency in requirements/base.in . It works right now, but only because it's being indirectly installed via celery / kombu.
Summary
This PR standardizes
sourcelibparsing inopenedx-eventsto keep metadata backward-compatible and consistent across event bus implementations.What changed
Behavior
Why
A recent Redis event bus change exposed inconsistencies around PEP 440 handling.
Keeping this logic in openedx-events avoids divergence across implementations and prevents breaking downstream consumers that expect sourcelib as tuple[int, ...].