Skip to content

[FE] Confirm every edit to a competency criterion or criteria group #785

Open

Description

@thelmick-unicon

User Story

As a course author, I want to confirm before I change a competency rule, in order to understand that my change affects future evaluations only and does not alter what learners have already earned.

Acceptance Criteria

Scenario: Saving a criterion's score threshold asks for confirmation first
  Given an author has changed a criterion's score threshold in the score popover
  When they choose Save in the popover
  Then a confirmation explaining that only future evaluations are affected is shown
    And the change is not yet saved

Scenario: Confirming saves the change
  Given the confirmation is shown for an edited criterion
  When the author confirms
  Then the change is saved
    And the confirmation closes

Scenario: Cancelling a score threshold change abandons the save and keeps the author's edits
  Given the confirmation is shown after the author chose Save in the score popover
  When the author cancels
  Then the change is not saved
    And the author's unsaved edits are still in the score popover

Scenario: Choosing a new any/all value for a criteria group asks for confirmation right away
  Given a criteria group set to combine its rules with "any"
  When the author chooses "all" in its any/all dropdown
  Then the same kind of confirmation is shown immediately
    And the change is not yet saved

Scenario: Cancelling an any/all change switches the dropdown back
  Given the confirmation is shown after the author changed a criteria group's dropdown from "any" to "all"
  When the author cancels
  Then the change is not saved
    And the dropdown shows "any" again

Scenario: The confirmation appears whether or not any learner has been evaluated
  Given a criterion that no learner has been evaluated against
  When an author changes its score threshold and chooses Save in the score popover
  Then the confirmation is still shown

Scenario: A save that fails does not claim to have succeeded
  Given the author has confirmed an edit
  When saving fails
  Then the failure is shown to the author
    And the author's edits are still on screen

Scenario: The confirmation is usable by keyboard and screen reader
  When the confirmation is shown
  Then focus moves into it
    And its message and buttons are announced
    And it can be dismissed from the keyboard

Description

Editing a competency criterion or criteria group on the Competency Management page saves immediately with no confirmation. An author has no indication that their change applies only going forward, and that learners already evaluated against the old rule keep the status they earned.

This ticket adds the confirmation step. The wording and behavior come from the design spike #775.

Figma Links:
E1 · Edit a rule's score (Cancel / Save)
E2 · Confirm rule change
E4 · Change a group's any/all
E5 · Confirm logic change
E2b · Save failed

Screenshots:

Image Image Image Image Image
Technical Details

This section is background and a suggested approach, not the ticket's source of truth. The User Story and Acceptance Criteria define what must be true when the work is done.

In short

Why the warning is unconditional. It appears on every criterion and group edit, not only when learner statuses already exist. Product chose that deliberately: a dialog that appears only sometimes trains authors to expect saves to be silent and then surprises them, and the frontend would need to know whether any learner had been evaluated in order to decide, which is information it does not have on this screen.

What the wording has to be true about. An edit changes future evaluations only. It never rewrites a status a learner already earned, and it never removes anything. That is the whole content of the message, and it is why this dialog is worded differently from the delete confirmation in #786.

The two edit surfaces, confirmed against the actual Competency Management UI (not assumed): a criterion's rule threshold (operator and percentage, in the "Competency Completion Rule" panel under a course/content association) and a criteria group's combining logic (the "any"/"all" dropdown). These are two different controls, not one shared save path, so each one opens the confirmation in its own way, as described below.

Take the wording from the design spike rather than this ticket. The starting text is a draft that #775 refines, along with the responsive and accessible behavior. Do not treat the sample copy in the spike as final without checking what #775 concluded.

How each edit surface opens the confirmation, per #775. Both surfaces apply a change as soon as it is made today, so there is no save step to intercept. #775 adds one where it is needed. The score popover gets Cancel and Save buttons, and Save opens the confirmation; the author's edits stay in the popover until they confirm or cancel. The any/all dropdown has no separate save step, so choosing a new value opens the confirmation right away. Cancelling that confirmation switches the dropdown back to its previous value, because a dropdown has no unsaved edit to keep on screen.

Implementation specifics

Activity

  1. moved this from Needs additional details to Drafting in Competency Criteria and Student Progresson Sep 14, 2026
  2. moved this from Ready for Community Review to Final Axim Review in Competency Criteria and Student Progresson Oct 16, 2026
  3. thelmick-unicon commented on Oct 19, 2026

    @thelmick-unicon
    Author

    The discussion period for this ticket is now complete, and we appreciate all the feedback. We'll be moving forward with development based on the current ticket pending final Axim sign-off. That said, the conversation doesn't have to stop. If you still have feedback, please continue to add to this ticket. We'll review anything new and determine whether it fits within the current timeline or makes more sense as its own ticket for future work. Thanks again for helping make this better!

    @jmakowski1123 This is ready for your final review. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions