Repository navigation
Conversation
|
Thanks for the pull request, @rodmgwgu! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Closes #525
Problem
priorityis meant to resolve conflicts betweenrole_extensionsonly. The compiler also applied it to base definitions: when two files declared the same category, permission, or role differently, the higher-priority file silently won. This was never in an ADR and contradicted validation, which already rejects such conflicts regardless of priority.Approach
SchemaCompileErrorregardless of priority (identical ones still merge). Extension resolution is unchanged.prioritydocs in ADR 0017, ADR 0023, the schema reference, and the JSON Schema.Manual testing instructions
In a tutor dev env with this repo mounted:
tutor dev run cms ./manage.py cms load_authz_schema --dry-run— applies cleanly (shipped schema has no conflicts).load_authz_schema— expect aCommandErrorreporting the conflict; DB untouched.role_extensionsentry — expect success, confirming priority still resolves extensions.Automated:
TestBaseDefinitionConflictscovers the new behavior; full schema suite (278 tests) passes.Rollback plan
Revert this PR. Contained to the compiler, its tests, and docs. No migration.
Retro compatibility
No behavior change for supported deployments: validation already rejected these conflicts before compile. Only a direct compiler call with conflicting base definitions now raises instead of picking a winner.
AI Usage
Kiro assisted with investigation, ADR authoring, and implementation, with human guidance on the decision and validation against the ADRs.
Merge checklist:
Fixedentry under Unreleased