Skip to content

fix(verawood): audit user course delete flag stale - #272

Open
dcoa wants to merge 4 commits into
openedx:release/verawoodfrom
eduNEXT:fix/audit-user-course-delete-flag-stale-verawood
Open

dcoa wants to merge 4 commits into
openedx:release/verawoodfrom
eduNEXT:fix/audit-user-course-delete-flag-stale-verawood

Conversation

@dcoa

@dcoa dcoa commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

Backports #271

dcoa and others added 2 commits October 15, 2026 22:31
DataTable only reads additionalColumns through react-table's visibleColumns
hook, whose memo doesn't depend on it. The actions cell created by
createActionsCell kept the isCourseEnabled resolver from the flag's loading
state, so course-scope rows rendered the "course authoring disabled" delete
button even after the flag resolved on. ActionsCell now reads the flag with
useCourseAuthoringFlag directly.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
(cherry picked from commit a4d2a95)
…w cell

ViewActionCell received isCourseEnabled through createViewActionCell, the
same factory pattern that left the audit actions cell stuck on the flag's
loading state. It only worked because TeamMembersTable passes columns inline;
memoizing them would freeze the view action as disabled. ViewActionCell now
reads the flag with useCourseAuthoringFlag directly, as master's
TeamMemberViewActionCell does, and createViewActionCell is removed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 15, 2026
@openedx-webhooks

Copy link
Copy Markdown

Thanks for the pull request, @dcoa!

This repository is currently maintained by @openedx/committers-frontend.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@codecov

codecov Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (release/verawood@d94f763). Learn more about missing BASE report.

Additional details and impacted files
@@                 Coverage Diff                 @@
##             release/verawood     #272   +/-   ##
===================================================
  Coverage                    ?   97.85%           
===================================================
  Files                       ?       71           
  Lines                       ?     1723           
  Branches                    ?      450           
===================================================
  Hits                        ?     1686           
  Misses                      ?       37           
  Partials                    ?        0           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

dcoa and others added 2 commits October 20, 2026 18:21
The view and delete actions only gate course authoring for course scopes.
Reading that from the role key misclassifies roles whose name doesn't
carry the "lib" prefix, so check the assignment's scope instead.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@mphilbrick211 mphilbrick211 added the backport PR backports a change from main to a named release. label Oct 22, 2026
@mphilbrick211 mphilbrick211 moved this from Needs Triage to Ready for Review in Contributions Oct 22, 2026
@mphilbrick211
mphilbrick211 requested a review from a team October 22, 2026 18:18

@bra-i-am bra-i-am left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working as expected!!

Before After
image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport PR backports a change from main to a named release. core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U

Projects

Status: Ready for Review

Development

Successfully merging this pull request may close these issues.

User audit view: course-scope delete control can stay "course authoring disabled" incorrectly

4 participants