Repository navigation
Conversation
DataTable only reads additionalColumns through react-table's visibleColumns hook, whose memo doesn't depend on it. The actions cell created by createActionsCell kept the isCourseEnabled resolver from the flag's loading state, so course-scope rows rendered the "course authoring disabled" delete button even after the flag resolved on. ActionsCell now reads the flag with useCourseAuthoringFlag directly. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit a4d2a95)
…w cell ViewActionCell received isCourseEnabled through createViewActionCell, the same factory pattern that left the audit actions cell stuck on the flag's loading state. It only worked because TeamMembersTable passes columns inline; memoizing them would freeze the view action as disabled. ViewActionCell now reads the flag with useCourseAuthoringFlag directly, as master's TeamMemberViewActionCell does, and createViewActionCell is removed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Thanks for the pull request, @dcoa! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release/verawood #272 +/- ##
===================================================
Coverage ? 97.85%
===================================================
Files ? 71
Lines ? 1723
Branches ? 450
===================================================
Hits ? 1686
Misses ? 37
Partials ? 0 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
The view and delete actions only gate course authoring for course scopes. Reading that from the role key misclassifies roles whose name doesn't carry the "lib" prefix, so check the assignment's scope instead. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>


Backports #271