Repository navigation
Modification of SAI_PORT_ATTR_CBFC_RECEIVER_NATIVE_TOTAL_CREDITS flags to CREATE_AND_SET - #2368
pullaraogunda wants to merge 3 commits into
Conversation
…EATE_AND_SET Signed-off-by: pullarao <pullarao.gunda@broadcom.com>
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
|
default value will be needed |
Signed-off-by: pullarao <pullarao.gunda@broadcom.com>
cc14865 to
b0b1858
Compare
| * @type sai_uint32_t | ||
| * @flags READ_ONLY | ||
| * @flags CREATE_AND_SET | ||
| * @isvlan false |
There was a problem hiding this comment.
isvlan is not needed as this flag is only used for uint16
Signed-off-by: pullarao <pullarao.gunda@broadcom.com>
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
|
If we modify the existing SAI_PORT_ATTR_CBFC_RECEIVER_NATIVE_TOTAL_CREDITS to create-and-set with a default value of 0, it breaks the existing use-case of retrieving the chip's allocation (which could be based on the port's ingress buffer pools and buffer profiles). A get on the attribute should return the user-configured values or the default (0) and not the actual allocation by the SDK. We should let SAI_PORT_ATTR_CBFC_RECEIVER_NATIVE_TOTAL_CREDITS continue to be read-only and treat as the operating value. Additionally introduce a new create-and-set attribute say SAI_PORT_ATTR_CBFC_RECEIVER_NATIVE_TOTAL_CREDITS_OVERRIDE to override the default value. Is something similar (say SAI_VIRTUAL_CHANNEL_ATTR_CBFC_RECEIVER_NATIVE_CREDIT_LIMIT_OVERRIDE) needed for SAI_VIRTUAL_CHANNEL_ATTR_CBFC_RECEIVER_NATIVE_CREDIT_LIMIT? |
rck-innovium
left a comment
rck-innovium
left a comment
There was a problem hiding this comment.
We should let SAI_PORT_ATTR_CBFC_RECEIVER_NATIVE_TOTAL_CREDITS continue to be read-only and treat as the operating value. Additionally introduce a new create-and-set attribute say SAI_PORT_ATTR_CBFC_RECEIVER_NATIVE_TOTAL_CREDITS_OVERRIDE to override the default value.
Currently, the SAI_PORT_ATTR_CBFC_RECEIVER_NATIVE_TOTAL_CREDITS attribute is defined as READ_ONLY. Hardware/SDK automatically allocated buffer credits at the receiver port based on default assumptions (e.g., port speed, standard cable length). The user could only query this attribute to retrieve the chip's default allocation.
There is currently no provision in SAI for a user to explicitly configure the receiver credits on the Rx side. While default allocations work for standard setups, administrators may need to override these values based on specific physical topologies, custom cable lengths, or requirements to use only a specific portion of the available credits.
This PR modifies the flag for SAI_PORT_ATTR_CBFC_RECEIVER_NATIVE_TOTAL_CREDITS from READ_ONLY to CREATE_AND_SET.