Repository navigation
ci: verify that a NuGet.org push actually published - #62
Merged
Merged
Conversation
--skip-duplicate reports every 409 as "already exists" and exits zero. Two dispatches went green under it while all four pushes were in fact refused, because the package ids fall under an ID prefix reservation this account does not hold; nothing reached the gallery and the lane still reported success. Removing the flag would trade that failure for another, since retrying a dispatch after a partial push must not abort on the package that already landed. It therefore stays, and stops being what decides success. A verification step now asks the flat container for the exact versions the pack step produced, which separates the two outcomes the flag conflates: a package that genuinely already existed answers yes, a package the gallery refused answers no. Validation is asynchronous, so the check waits rather than reading the registry once, and fails naming the versions that never appeared.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--skip-duplicatereports every 409 as "already exists" and exits zero. Two dispatches went green under it while all four pushes were in fact refused by an ID prefix reservation; nothing reached the gallery and the lane still reported success.Removing the flag would trade that failure for another, since retrying a dispatch after a partial push must not abort on the package that already landed. It therefore stays, and stops being what decides success. A verification step now asks the flat container for the exact versions the pack step produced, which separates the two outcomes the flag conflates: a package that genuinely already existed answers yes, a package the gallery refused answers no. Validation is asynchronous, so the check waits rather than reading the registry once, and fails naming the versions that never appeared.
Verified by running the script against nuget.org: a published package (
Newtonsoft.Json 13.0.3) passes and correctly ignores the sibling.snupkg; an unpublished one polls and then fails with exit 1.